Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coretasks: alert owner if nick in RPL_WELCOME does not match config #2215

Merged
merged 1 commit into from
Dec 1, 2021
Merged

coretasks: alert owner if nick in RPL_WELCOME does not match config #2215

merged 1 commit into from
Dec 1, 2021
+23 −0

Conversation

dgw
Copy link
Member

@dgw dgw commented Nov 28, 2021

Description

Inspired by a recent PR to the "horse docs" site (ircdocs/modern-irc#146), which adds a paragraph about this.

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches

New log output

The result of "test[ing] the functionality of the things this change touches".

stdout/logging 
...
[2021-11-27 20:43:25,272] sopel.coretasks      INFO     - End of client capability negotiation requests.
[2021-11-27 20:43:25,307] sopel.coretasks      CRITICAL - RPL_WELCOME indicated the server did not accept the bot's
                                                          configured nickname. Requested
                                                          'ThisIsAVeryLongNickThatRizonWillTruncateBecauseItsLongerThan30Characters';
                                                          got 'ThisIsAVeryLongNickThatRizonWi'. This can cause unexpected
                                                          behavior. Please modify the configuration and restart the bot.
[2021-11-27 20:43:25,310] sopel.coretasks      INFO     - Joining 1 channels (with JOIN throttle OFF); this may take a moment.
...
raw log 
...
2021-11-27 20:43:25,307 <<      ':irc.sxci.net 001 ThisIsAVeryLongNickThatRizonWi :Welcome to the Rizon Internet Relay Chat Network ThisIsAVeryLongNickThatRizonWi\r\n'
2021-11-27 20:43:25,309 >>      "PRIVMSG dgw :Hi, I'm your bot, ThisIsAVeryLongNickThatRizonWillTruncateBecauseItsLongerThan30Characters. The IRC server didn't assign me the nick you configured. This can cause problems for me, and make me do weird things. You'll probably want to stop me, figure out why my nick isn't acceptable, and fix that before starting me again.\r\n"
2021-11-27 20:43:25,310 >>      'MODE ThisIsAVeryLongNickThatRizonWillTruncateBecauseItsLongerThan30Characters +B\r\n'
...

@dgw dgw added the Tweak label Nov 28, 2021
@dgw dgw added this to the 7.1.7 milestone Nov 28, 2021
@dgw dgw requested a review from a team November 28, 2021 17:51
@dgw
coretasks: alert owner if nick in RPL_WELCOME does not match config
8252e1f 
Inspired by a recent PR to the "horse docs" site, which adds a paragraph
about this.
@dgw dgw merged commit fbe6ad4 into master Dec 1, 2021
@dgw dgw deleted the welcome-nick branch December 1, 2021 17:06
dgw added a commit that referenced this pull request Dec 1, 2021
@dgw
Backport pull request #2215
f1943d7 
coretasks: alert owner if nick in `RPL_WELCOME` does not match config
dgw added a commit that referenced this pull request Dec 11, 2021
@dgw
Backport pull request #2215
4fb17d4 
coretasks: alert owner if nick in `RPL_WELCOME` does not match config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Exirel Exirel Exirel approved these changes

Assignees
No one assigned
Labels
Tweak
Projects
None yet
Milestone
7.1.7
Development

Successfully merging this pull request may close these issues.
2 participants
@dgw @Exirel